Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify getter functions to public variables, default storage variables to internal #199

Open
jtriley-eth opened this issue Nov 25, 2023 · 2 comments
Labels
A-core Area: core C-decompile Command: decompile D-average Difficulty: average good first issue Good for new contributors P-normal Priority: normal T-feature Type: feature

Comments

@jtriley-eth
Copy link

Component

Heimdall (Core)

Describe the feature you would like

at the time of writing, storage values are listed as "public" by default, however, this is not the case.

also, variables declared public in the original source code become getter functions in the heimdall decompile output.

proposal is to add a simplification rule to simple getter functions as follows:

current:

contract Decompiled {
    bytes32 public stor_a;

    function SEAPORT() public view payable returns (uint256) {
        require(msg.value);
        require((0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc + msg.data.length) < 0);
        return address(stor_a);
    }
}

proposed:

contract Decompiled {
    address public SEAPORT;
}
@jtriley-eth jtriley-eth added the T-feature Type: feature label Nov 25, 2023
@Jon-Becker Jon-Becker added C-decompile Command: decompile D-average Difficulty: average P-normal Priority: normal A-core Area: core labels Nov 25, 2023
@Jon-Becker Jon-Becker self-assigned this Nov 25, 2023
@Jon-Becker
Copy link
Owner

Thank you for opening! I'll tackle asap!

@Jon-Becker Jon-Becker added the good first issue Good for new contributors label Dec 1, 2023
@Jon-Becker Jon-Becker removed their assignment Dec 9, 2023
@Jon-Becker
Copy link
Owner

THIS IS STILL OPEN????

I'll prio for next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: core C-decompile Command: decompile D-average Difficulty: average good first issue Good for new contributors P-normal Priority: normal T-feature Type: feature
Projects
None yet
Development

No branches or pull requests

2 participants