Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codebase hardening #217

Open
Jon-Becker opened this issue Dec 2, 2023 · 0 comments
Open

chore: codebase hardening #217

Jon-Becker opened this issue Dec 2, 2023 · 0 comments
Labels
D-chore Difficulty: chore good first issue Good for new contributors P-normal Priority: normal T-debt Type: code debt

Comments

@Jon-Becker
Copy link
Owner

Jon-Becker commented Dec 2, 2023

Use proper error handling everywhere. Heimdall should never panic, and most nontrivial functions should be made to return Result<_, _>s

Todo:

  • remove unsafe .unwrap()s. (If an unwrap is safe, use .expect()
  • remove all instances of std::process::exit
  • implement crate::Error for each crate (heimdall-core, heimdall-cli, etc). See here for an example.
  • Convert functions to Result<_, crate::Error> wherever possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-chore Difficulty: chore good first issue Good for new contributors P-normal Priority: normal T-debt Type: code debt
Projects
None yet
Development

No branches or pull requests

1 participant