Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(decode): support decoding of raw logs #262

Open
Jon-Becker opened this issue Dec 31, 2023 · 4 comments · May be fixed by #274
Open

feat(decode): support decoding of raw logs #262

Jon-Becker opened this issue Dec 31, 2023 · 4 comments · May be fixed by #274
Assignees
@jensenity
Labels
A-core Area: core C-decode Command: decode D-hard Difficulty: hard P-normal Priority: normal T-feature Type: feature

Comments

@Jon-Becker
Copy link
Owner

This is a problem because you don't know the order of parameters, or if a parameter is indexed or not.

If you want to tackle this and i haven't, send me a more drop a comment!
@Jon-Becker Jon-Becker added A-core Area: core C-decode Command: decode D-hard Difficulty: hard P-normal Priority: normal T-feature Type: feature labels Dec 31, 2023
@jensenity
Copy link

@phyyou let's tackle on this

@phyyou
Copy link

phyyou commented Jan 2, 2024

👀

@phyyou
Copy link

phyyou commented Jan 2, 2024 •
edited

I'm guessing this issue is pointing to a detailed code location, right?

@Jon-Becker @jensenity

@Jon-Becker
Copy link
Owner Author

yep! this should be implemented as a TryFrom ideally, and should maybe return a Vec of possibilities since decoding raw logs is very ambiguous.

@phyyou phyyou linked a pull request Jan 4, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensenity jensenity

Labels
A-core Area: core C-decode Command: decode D-hard Difficulty: hard P-normal Priority: normal T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(decode): support decoding of raw logs phyyou/heimdall-rs
3 participants
@phyyou @jensenity @Jon-Becker