Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: bin missing from package.json and bin/typestat pointing to wrong place? #1496

Open
3 tasks done
rubiesonthesky opened this issue Mar 31, 2024 · 2 comments · May be fixed by #1508
Open
3 tasks done

🐛 Bug: bin missing from package.json and bin/typestat pointing to wrong place? #1496

rubiesonthesky opened this issue Mar 31, 2024 · 2 comments · May be fixed by #1508
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛

Comments

@rubiesonthesky
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Before create-typescript-app migration, there was this is package.json

	"bin": {
		"typestat": "bin/typestat"
	},

No it's no longer there.

Also bin/typestat should be changed to import from "../lib/cli/runCli"?

Actual

  • bin is missing

Additional Info

I'm trying to understand how I could run development build locally, but not succeeding.

I also think there are a lot unnecessary files in the npm package, looking at here: https://www.npmjs.com/package/typestat?activeTab=code - that was releaset before create-typescript-app migration, so it may be that the situation is now different.

  • .github
  • .husky
  • eslint stuff
  • git stuff
  • prettier stuff
  • jest
  • dependaconfig
  • renovate.json (There is another renovate.json in .github, I think there should be only one?)
  • tsconfig.json (I have understood that this should never go to packages?)
@rubiesonthesky rubiesonthesky added type: bug Something isn't working :( 🐛 area: tooling Managing the repository's maintenance 🛠️ labels Mar 31, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! 🙏 label Apr 1, 2024
@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Apr 1, 2024

Heh in retrospect I should have asked for your review on #1435. I was nervous to take up more of your time given how awesome you've already been. But, yeah, there are a lot of little things I missed there that should be cleaned up. Accepting PRs for whatever you can spot! And anything you don't have time for I can get to. ❤️

@rubiesonthesky
Copy link
Collaborator Author

TBH, sometimes those big PRs are impossible to review and it's more important to get them going than try to make sure that everything is perfect. I read the PR but I did not spot this there, so it would have not made difference did you wait for me or not :)

@rubiesonthesky rubiesonthesky linked a pull request Apr 1, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance 🛠️ status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants