Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bin to package.json #1508

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

rubiesonthesky
Copy link
Collaborator

PR Checklist

Overview

I think it would be good idea to do alpha / experimental release after this to check that everything is correct :)

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 78.64%. Comparing base (e484ffc) to head (7e79653).
Report is 3 commits behind head on main.

Files Patch % Lines
src/options/findRawOptions.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
+ Coverage   78.62%   78.64%   +0.02%     
==========================================
  Files         175      175              
  Lines       10957    10978      +21     
  Branches     1021     1021              
==========================================
+ Hits         8615     8634      +19     
- Misses       2338     2340       +2     
  Partials        4        4              
Flag Coverage Δ
mutation 73.10% <0.00%> (-0.15%) ⬇️
unit 28.49% <84.84%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubiesonthesky
Copy link
Collaborator Author

I changed build workflow so that it tries to run the cli. And now we can see that the cli is working in CI too.

@rubiesonthesky
Copy link
Collaborator Author

Coverage change is because the auto format changes due using default import. I guess I need to add prompt variable so the formatting does not need to change.

@JoshuaKGoldberg
Copy link
Owner

I think it would be good idea to do alpha / experimental release after this to check that everything is correct :)

Agreed. I'm a bit swamped this week but will try to get through this and #1515 soon!

@rubiesonthesky
Copy link
Collaborator Author

Agreed. I'm a bit swamped this week but will try to get through this and #1515 soon!

No worries. To make checking this easier, this is how I tested locally (same as in the CI) :)

  • pnpm build
  • pnpm link .
  • pnpm typestat

@@ -5,7 +5,8 @@ jobs:
- uses: actions/checkout@v4
- uses: ./.github/actions/prepare
- run: pnpm build
- run: node ./lib/index.js
- run: pnpm link .
- run: pnpm typestat
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL of this strategy, I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: bin missing from package.json and bin/typestat pointing to wrong place?
2 participants