Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Tests: Add end-to-end tests? #1506

Open
JoshuaKGoldberg opened this issue Apr 1, 2024 · 2 comments
Open

🧪 Tests: Add end-to-end tests? #1506

JoshuaKGoldberg opened this issue Apr 1, 2024 · 2 comments
Labels
area: documentation Improvements or additions to docs 📝 area: testing Improving how the repository's tests are run and/or code is tested 🧪 status: blocked Waiting for something else to be resolved 🙅

Comments

@JoshuaKGoldberg
Copy link
Owner

Overview

There've been a bunch of (excellent) issues filed by @rubiesonthesky (e.g. #1498) as a result of running TypeStat on this repo. Which indicates there's not enough test coverage to exercise TypeStat on larger repos such as itself.

Proposal: how about adding some end-to-end tests that truly run TypeStat -not just the existing "mutation" (integration-style) tests- on full repositories?

  • TypeStat itself?
  • A few small example repos of various styles (JS, mixed-JS-TS, TS)
  • Perhaps as a followup: cloning known good repos at particular commits and running on them?

This would come after #1476.

@JoshuaKGoldberg JoshuaKGoldberg added status: in discussion Not yet ready for implementation or a pull request area: documentation Improvements or additions to docs 📝 area: testing Improving how the repository's tests are run and/or code is tested 🧪 labels Apr 1, 2024
@rubiesonthesky
Copy link
Collaborator

Yeah, I totally think this is good thing!

@JoshuaKGoldberg JoshuaKGoldberg added status: blocked Waiting for something else to be resolved 🙅 and removed status: in discussion Not yet ready for implementation or a pull request labels Apr 1, 2024
@rubiesonthesky
Copy link
Collaborator

We also need some test that running clip works after building to ensure we do not release anything broken.

In short, something that launch typestat and checks that it prints at least the first question.

In the “bin” PR , I changed build workflow so that it launches the cli. But there is nothing to check that it actually prints anything meaningful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Improvements or additions to docs 📝 area: testing Improving how the repository's tests are run and/or code is tested 🧪 status: blocked Waiting for something else to be resolved 🙅
Projects
None yet
Development

No branches or pull requests

2 participants