Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: strictNonNullAssertions does not understand that undefined is accepted in union array #1518

Open
3 tasks done
rubiesonthesky opened this issue Apr 3, 2024 · 0 comments
Labels
status: accepting prs Please, send a pull request to resolve this! 馃檹 type: bug Something isn't working :( 馃悰

Comments

@rubiesonthesky
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

I expected it to not add ! to undefined

const someArray: (string | undefined)[] = [];
someArray.push(undefined);

Actual

const someArray: (string | undefined)[] = [];
someArray.push(undefined!);

Additional Info

typestat.json

[
    {
        "fixes": {
            "strictNonNullAssertions": true
        },
        "include": [
            "src/**/*.{ts,tsx}"
        ],
        "projectPath": "./tsconfig.json",
        "types": {
            "strictNullChecks": true
        }
    }
]

tsconfig

{
	"compilerOptions": {
		"declaration": true,
		"declarationMap": true,
		"esModuleInterop": true,
		"module": "NodeNext",
		"moduleResolution": "NodeNext",
		"noEmit": true,
		"outDir": "lib",
		"resolveJsonModule": true,
		"skipLibCheck": true,
		"sourceMap": true,
		"strict": true,
		"target": "ES2022"
	},
	"include": ["src", "test/*.ts"]
}
@rubiesonthesky rubiesonthesky added type: bug Something isn't working :( 馃悰 status: accepting prs Please, send a pull request to resolve this! 馃檹 labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 馃檹 type: bug Something isn't working :( 馃悰
Projects
None yet
Development

No branches or pull requests

1 participant