Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused support for file glob from command line #1534

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: remove unused support for file glob from command line #1534

wants to merge 8 commits into from

Conversation

rubiesonthesky
Copy link
Collaborator

@rubiesonthesky rubiesonthesky commented Apr 5, 2024 •
edited by JoshuaKGoldberg

PR Checklist

Overview

There seems to be undocumented code path that could potentially support giving file glob from command line. Since there is no tests for this and no documentation, it's hard to say is it working as intended currently. I think the current mindset is that these kind of settings would be in the json config file.

This change makes the code simpler to understand.

@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 78.98%. Comparing base (f6dc470) to head (d2a2d17).
Report is 1 commits behind head on main.

Files Patch % Lines
src/index.ts 0.00% 5 Missing ⚠️
src/options/loadPendingOptions.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
+ Coverage   78.62%   78.98%   +0.35%     
==========================================
  Files         175      175              
  Lines       10957    10942      -15     
  Branches     1021     1027       +6     
==========================================
+ Hits         8615     8642      +27     
+ Misses       2338     2296      -42     
  Partials        4        4
Flag Coverage Δ
mutation 73.33% <0.00%> (+0.08%) ⬆️
unit 28.66% <20.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubiesonthesky rubiesonthesky marked this pull request as ready for review April 5, 2024 13:07
@rubiesonthesky rubiesonthesky mentioned this pull request Apr 5, 2024
Open
3 tasks
@rubiesonthesky rubiesonthesky added the type: cleanup Tech debt or other code/repository cleanups 🧹 label Apr 5, 2024
@rubiesonthesky rubiesonthesky mentioned this pull request Apr 7, 2024
Open
3 tasks
JoshuaKGoldberg
JoshuaKGoldberg requested changes Apr 9, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, and wowee unit tests even! Great 😄.

Requesting changes just on those lovely tests.

src/collectFileNames.test.ts Outdated Show resolved Hide resolved
src/collectFileNames.test.ts Outdated Show resolved Hide resolved
src/collectFileNames.test.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author Needs an action taken by the original poster and removed type: cleanup Tech debt or other code/repository cleanups 🧹 labels Apr 9, 2024
rubiesonthesky and others added 2 commits April 9, 2024 18:42
@rubiesonthesky @JoshuaKGoldberg
Apply suggestions from code review
bfae15e 
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@rubiesonthesky
update test based on PR comments
9d3c489
@rubiesonthesky
Copy link
Collaborator Author

rubiesonthesky commented Apr 9, 2024 •
edited

Thanks for feedback. :) Fixed mentioned issues.

Lint step is failing because eslint config is not found for Eslint 9. But this branch should be still using Eslint 8?!

I don't know why it tried to use Eslint 9. But main is also failing because Eslint 9 PR was automerged when it's in fact failing. :/

@JoshuaKGoldberg
Copy link
Owner

Eslint 9 PR was automerged when it's in fact failing.

blagh this must be because I didn't set a branch protection rule.

@rubiesonthesky rubiesonthesky removed the status: waiting for author Needs an action taken by the original poster label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠 Cleanup: Remove non-documented / used support for giving file glob from command line
2 participants
@rubiesonthesky @JoshuaKGoldberg