Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Also remove existing "mocha" package.json field #1374

Open
2 tasks done
JoshuaKGoldberg opened this issue Mar 7, 2024 · 0 comments
Open
2 tasks done
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

#1372 tracks deleting any existing Mocha options file in a migration... but Mocha can alternately be configured with a "mocha" key in the package.json of a project. Let's have migration also delete that "mocha" in the package.json if it exists.

Additional Info

The logic to remove existing unnecessary fields in a package.json is around here:

// Remove fields we know we don't want, such as old or redundant configs
eslintConfig: undefined,
husky: undefined,
prettierConfig: undefined,
types: undefined,

Similar issue for Jest: #1372

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant