Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: a github action to track bundle size #1398

Open
2 tasks done
dlvhdr opened this issue Mar 19, 2024 · 2 comments
Open
2 tasks done

馃殌 Feature: a github action to track bundle size #1398

dlvhdr opened this issue Mar 19, 2024 · 2 comments
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request

Comments

@dlvhdr
Copy link

dlvhdr commented Mar 19, 2024

Bug Report Checklist

Overview

A github action that comments on the PR with a diff of the current bundle size vs the one in the base.
Something like https://github.com/Schniz/benchy-action?tab=readme-ov-file or bundlemon.

Additional Info

No response

@dlvhdr dlvhdr added the type: feature New enhancement or request label Mar 19, 2024
@JoshuaKGoldberg
Copy link
Owner

Hmm, this is an interesting idea, thanks for filing... I personally don't find much benefit from these, but I know that other folks do.

My personal leanings are to say 'no' on the grounds of this only being applicable to some TypeScript packages. But I might be wrong there - leaving open in discussion in case you / anybody wants to push back on that.

@JoshuaKGoldberg JoshuaKGoldberg added the status: in discussion Not yet ready for implementation or a pull request label Mar 24, 2024
@dlvhdr
Copy link
Author

dlvhdr commented Mar 25, 2024

Not sure either if there's a solution that fits every project. I did see https://github.com/preactjs/compressed-size-action.

Anyway I have something similar in my work repo, because we recently included fakerjs in our bundle by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

2 participants