Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ESLint dependency to 8.x #39

Closed
Tracked by #28
JoshuaKGoldberg opened this issue Sep 13, 2023 · 1 comment · Fixed by #40
Closed
Tracked by #28

Bump ESLint dependency to 8.x #39

JoshuaKGoldberg opened this issue Sep 13, 2023 · 1 comment · Fixed by #40
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Splitting out of #33: per https://eslint.org/docs/latest/extend/custom-processors#file-extension-named-processor, this package's file extension based processor approach is now deprecated. Fun!
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! area: tooling Managing the repository's maintenance labels Sep 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 13, 2023
Closed
@JoshuaKGoldberg
Copy link
Owner Author

Relevant: eslint/rfcs#31 🙃

This was referenced Sep 13, 2023
Closed
Merged
Merged
Closed
Closed
Closed
JoshuaKGoldberg added a commit that referenced this issue Oct 17, 2023
@JoshuaKGoldberg
feat!: ESLint 8 and jsonc-eslint-parser (#40)
d1a2843 
Fixes #39; fixes #43.

Moves to the external `jsonc-eslint-parser` because:

* #43: it's a good ecosystem standard
* ESLint's RuleTester doesn't support this usage of processors
(#40 (comment))

Also removes the `disparity` dependency, in favor of directly telling
users to run the auto-fixer. This is the strategy other plugins such as
[`eslint-plugin-simple-import-sort`](https://github.com/lydell/eslint-plugin-simple-import-sort)
take. It's simpler to implement, makes for easier-to-read error
messages, and reduces the size of `node_modules`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: ESLint 8 and jsonc-eslint-parser JoshuaKGoldberg/eslint-plugin-package-json
1 participant
@JoshuaKGoldberg