Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Bring in eslint-plugin-node-dependencies's valid-semver rule #49

Open
JoshuaKGoldberg opened this issue Sep 20, 2023 · 1 comment
Open

🚀 Feature: Bring in eslint-plugin-node-dependencies's valid-semver rule #49

JoshuaKGoldberg opened this issue Sep 20, 2023 · 1 comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Full Recommended ...

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 20, 2023 •
edited

Splitting out from #43 (comment) & #42: eslint-plugin-node-dependencies has a valid-semver rule. Let's merge it into this package!

https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/valid-semver.html

Blocked on #40, but once that PR is merged this will be good to go. ✅
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: blocked Waiting for something else to be resolved labels Sep 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 20, 2023
Open
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: blocked Waiting for something else to be resolved labels Jan 20, 2024
@JoshuaKGoldberg
Copy link
Owner Author

Note that this is different from #130 -> #135. valid-version is for the root-level version. This is for individual package versions.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Bring in eslint-plugin-node-dependencies's valid-semver rule 🚀 Featuer: Bring in eslint-plugin-node-dependencies's valid-semver rule Jan 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Featuer: Bring in eslint-plugin-node-dependencies's valid-semver rule 🚀 Feature: Bring in eslint-plugin-node-dependencies's valid-semver rule Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Full Recommended Config
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg