Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flow node type guards #249

Closed
wants to merge 3 commits into from
Closed

feat: add flow node type guards #249

wants to merge 3 commits into from

Conversation

RebeccaStevens
Copy link
Collaborator

PR Checklist

Overview

Adds type guards for flow nodes.

@RebeccaStevens RebeccaStevens added the type: feature New enhancement or request 🚀 label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #249 (ab1cade) into main (55bfa2c) will decrease coverage by 1.45%.
The diff coverage is 5.88%.

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   46.30%   44.86%   -1.45%     
==========================================
  Files          20       21       +1     
  Lines         460      477      +17     
  Branches      181      189       +8     
==========================================
+ Hits          213      214       +1     
- Misses        218      234      +16     
  Partials       29       29              
Flag Coverage Δ
4.3.5 44.44% <5.88%> (-1.43%) ⬇️
4.6.4 44.65% <5.88%> (-1.44%) ⬇️
4.9.5 44.86% <5.88%> (-1.45%) ⬇️
latest 44.65% <5.88%> (-1.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/flowNodes/typeGuards/index.ts 0.00% <0.00%> (ø)
src/nodes/typeGuards/single.ts 71.42% <0.00%> (-1.30%) ⬇️
src/flags.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg
Copy link
Owner

Closing pending #248 to keep the queue small

@JoshuaKGoldberg JoshuaKGoldberg deleted the flow-nodes branch August 5, 2023 00:02
@JoshuaKGoldberg JoshuaKGoldberg restored the flow-nodes branch August 5, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New enhancement or request 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add type guards for flow nodes
2 participants