Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: be able to determine where a type is defined #501

Open
2 tasks done
RebeccaStevens opened this issue May 3, 2024 · 2 comments
Open
2 tasks done
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request 馃殌

Comments

@RebeccaStevens
Copy link
Collaborator

Bug Report Checklist

Overview

Essentially adds the typeMatchesSpecifier function from ts-declaration-location.

This function is only for testing where a type is defined, not filtering the type based on its name or anything else. That could be new functionality in the future.

Additional Info

No response

@RebeccaStevens RebeccaStevens added the type: feature New enhancement or request 馃殌 label May 3, 2024
@JoshuaKGoldberg
Copy link
Owner

It's an interesting idea! My personal inclination is that this should be a separate package. ts-api-utils is a lot of very generalized utilities. typesMatchesSpecifier is a pretty specific format that's also still relatively new in usage. Having the separate ts-declaration-location be able to iterate on its own feels right to me. Just my two cents 馃槃 putting into discussion.

@JoshuaKGoldberg JoshuaKGoldberg added the status: in discussion Not yet ready for implementation or a pull request label May 3, 2024
@RebeccaStevens
Copy link
Collaborator Author

Yeah that makes sense. I'm perfectly happy to continue with it in its own repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request 馃殌
Projects
None yet
Development

No branches or pull requests

2 participants