Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is impossible to enter more than 4 digits in input, when thousandSeparator="," is used on input #1349

Open
volodymyrmilovanov2022 opened this issue Apr 15, 2024 · 4 comments

Comments

@volodymyrmilovanov2022
Copy link

volodymyrmilovanov2022 commented Apr 15, 2024

馃悶 bug report

Is this a regression?

Yes, the previous version in which this bug was not present was: 16.3.5

Description

When I use mask="separator.2" and set thousandSeparator="," on input, i cannot enter more than 4 digits. It was Ok when i had 16.3.5 version, and has been broken after update to 17.0.7

馃敩 Minimal Reproduction

https://stackblitz.com/edit/angular-17-starter-project-evcdxx?file=src%2Fmain.ts

馃實 Your Environment

Angular Version:17





Anything else relevant?

@LYSBALL
Copy link

LYSBALL commented Apr 16, 2024

I am facing the same issue, the problem started in 17.0.5
Version 17.0.4 works fine for me.

@AbbTek
Copy link

AbbTek commented Apr 17, 2024

Same issue here 17.0.4 works fine for me.

dhaselhan pushed a commit to bcgov/alcs that referenced this issue Apr 23, 2024
* Currrently open issue breaking NGX Mask when it has decimal separators JsDaddy/ngx-mask#1349
* Downgrade to 17.0.4 which does not have the issue
dhaselhan pushed a commit to bcgov/alcs that referenced this issue Apr 23, 2024
* Currrently open issue breaking NGX Mask when it has decimal separators JsDaddy/ngx-mask#1349
* Downgrade to 17.0.4 which does not have the issue
@russcarver
Copy link

russcarver commented Apr 26, 2024

This is still an issue after I upgraded to Angular 17.3.6 (from 16.2.12) with ngx-mask 17.0.7. I was using ngx-mask 16.4.2 with Angular 16.2.12 and it was working fine.

After downgrading and trying 17.0.0, 17.0.1, 17.0.2, 17.0.3, 17.0.4, and 17.0.7 (all tested) as well as 16.4.2 (with Angular 17.3.6) it still is broken.

My has the following:

When I create my FormGroup, this FormControl is of type: FormControl<undefined | string> and the default value is undefined.

Removing "aria-labelledby", and "autocomplete" had no effect.

Here's what happens:
When I type "1234", it's fine. When I add "5", it becomes "123". When I then add "6", it becomes "1236". When I then add "7", it becomes "123" again and so on. It will not allow me to enter a decimal point nor numbers after it.

This puts my Angular 17 upgrade ON HOLD until this can be resolved.


UPDATE: After setting the ngx-mask version to 17.0.4, clearing all node_modules & cache directories, and reinstalling everything, it appears to be working.

@joshuaGnol
Copy link

Having same issue with version 17.0.8 using FormControl
When input number 12345, it will return as 123.00

https://stackblitz.com/edit/angular-txwonf?file=package.json,src%2Fmain.ts,src%2Fkarma.conf.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants