Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests for wrapper correctness #317

Open
melonedo opened this issue Jul 22, 2021 · 1 comment
Open

No tests for wrapper correctness #317

melonedo opened this issue Jul 22, 2021 · 1 comment
Labels

Comments

@melonedo
Copy link
Contributor

Currently, we only have tests for the integrity of the generated wrapper, while correctness needs to be tested on downstream packages.
Maybe we could build a custom test library in C (with BinaryBuilder), then relevant tests can be hosted on Clang.jl itself.

@Gnimuc Gnimuc added the test label Jul 22, 2021
@Gnimuc
Copy link
Member

Gnimuc commented Jul 22, 2021

+1 for this.

There were some test cases before. I removed them because all of these test cases were too trivial.

For new features like bitfield, we do need decent unit tests. It's not easy to work with BB2 when developing the package interactively. It turns out this is probably an ideal use case for ClangComplier.jl with which we can compile the C code within Julia and call the library through LLVM.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants