-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isuppercase
/islowercase
fail on invalid characters
#54343
Comments
I think we should clearly be returning Malformed chars can never get passed to utf8proc in the first place — if there is no way to convert them to a On invalid codepoints, |
Isn't this a bug in Or should we have another predicate in this case, where it's failing because it is an overlong encoding ( |
Maybe Lines 414 to 415 in dbf0bab
should just be calling Or better yet just Or better yet, shouldn't we have a predicate hascodepoint(c::AbstractChar) = !(ismalformed(c) | isoverlong(c)) to check whether one can call |
MWE:
Either this is a requirement, or we can safely return
false
here, as is done for malformed characters. Does utf8proc handle invalid/malformed chars on its own? The docs aren't clear about this.The text was updated successfully, but these errors were encountered: