Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle waiting for ASF restarts #1451

Open
Aareksio opened this issue Jun 26, 2021 · 1 comment
Open

Properly handle waiting for ASF restarts #1451

Aareksio opened this issue Jun 26, 2021 · 1 comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@Aareksio
Copy link
Member

Aareksio commented Jun 26, 2021

Purpose

Currently the Setup page is responsible for waiting for ASF restart, furthermore, it is currently unable to wait for restart after successful ASF update.

Solution

We should separate restart logic into separate component. This way we do not extend already overly complicated Setup page. Thanks to the separation, we may be able to easily handle update process as well.

The new loading component can be stripped of the layout elements, as with ASF offline we could not load additional assets anyway. Before requesting ASF update, we could preload the component to cache, so it is possible to render even without Kestrel running:

async function preload () {
  await import('@/path/to/component.vue')
}

Alternatives

Archi said no. He did not say no.

Additional information

As for the update process, we should do the following:

  1. Preload restart component
  2. Send Update request
    2.1. If the response arrives within 1,000 ms, proceed as normal - show error
  3. Else redirect to Update component, let it handle the response
  4. Inside restart component show loader, wait for response
    4.1. If error response arrives, proceed as normal - show error
  5. Else start waiting for restart

Alternatively we could straight redirect to the restart component and let it handle update fully. This may not be the most user friendly experience (the update request can return "no update available" really quickly), but should be much easier to implement.

@Aareksio Aareksio added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 26, 2021
@JustArchi
Copy link
Member

@MrBurrBurr MrBurrBurr added 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Development

No branches or pull requests

3 participants