Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to clear password (and other sensitive data fields) in config #1650

Open
5 tasks done
Rudokhvist opened this issue Dec 2, 2023 · 0 comments
Open
5 tasks done
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request.

Comments

@Rudokhvist
Copy link
Contributor

Checklist

  • I read and understood ASF-ui's Contributing Guidelines
  • I also read FAQ
  • My idea doesn't duplicate existing ASF-ui functionality described on the wiki
  • I believe that my idea falls into ASF-ui's scope and should be offered as part of ASF-ui built-in functionality
  • This is not ASF suggestion

Enhancement purpose

ASF supports work with no specified password (or other sensitive data), that can be requested by on-demand basis via console or input command. But if password is already set in config - ASF-ui have no means to remove it, only to replace it with another one, if field is left empty - old value preserved.

Solution

I suggest to add a checkbox or a button to allow users to specify that ASF-ui should actually send null instead of password to remove it from config file. Similar logic can be applied to other sensitive fields, at least the ones that allow requesting them via console/input command.

Why currently available solutions are not sufficient?

If ASF-ui supports editing config files - removing properties should be available too.

Can you help us with this enhancement idea?

Somehow, I can test and offer feedback, but can't code

Additional info

Honestly, I don't even need it personally. But since I noticed lack of this possibility I decided to report it, and the rest is up to you.

@Rudokhvist Rudokhvist added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Dec 2, 2023
@MrBurrBurr MrBurrBurr added 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request. and removed 🧐 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Dec 6, 2023
@MrBurrBurr MrBurrBurr changed the title Add possibility to clear password (and optionally other sensitive data fields) in config file(s). Add possibility to clear password (and other sensitive data fields) in config Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👍 PR-ok Issues marked with this label are good candidates for being accepted in a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants