Visual Studio 2017 support

[Owen0225]

As shown in the figure

[JustasMasiulis]

Could you provide compiler output (output tab instead of the errors tab) so I can see the error code or at least translate what they say?

[Paavs-Git]

Seems related: I have this in line 139 and 182

Building gives this error:

And this note:

Building as Release x64, happens with 'ISO C++17 Standard (/std:c++17)' and 'ISO C++ Latest Draft Standard (/std:c++latest)', VS 2017.

If you need more info, let me know how to get it.

[Paavs-Git]

Commit b37d4de builds without error and seems to work with 'printf', 'wprintf', 'puts', and '_putws'.

With 'cout' it gives an error for wide chars (chars work fine):

I'm fine without the optimizations and can work around 'cout' so for now that commit works as a work-around. Thanks for sharing the project.

[Owen0225]

Seems to be just a prompt error, compiled through

[JustasMasiulis]

@Paavs-Git So I looked into it and the only mitigation I could do in my code is add an #if defined(_MSC_VER) && _MSCVER > ... and duplicate the code. I'd really recommend to just update your visual studio and it would solve itself.

[Paavs-Git]

@JustasMasiulis I assume you mean to VS 2019, correct? I'm using Win 10 LTSB (2016) which is not supported by VS 2019, unfortunately.
If you could post what to add to support VS 2017 it would be nice, if you don't want to bother I'd just be missing the recent optimizations, since the previous commit works for me as mentioned, and I'm fine with that too.
Thanks for looking into it.

[JustasMasiulis]

@JustasMasiulis I assume you mean to VS 2019, correct? I'm using Win 10 LTSB (2016) which is not supported by VS 2019, unfortunately.

Yup :(

If you could post what to add to support VS 2017 it would be nice, if you don't want to bother I'd just be missing the recent optimizations, since the previous commit works for me as mentioned, and I'm fine with that too.

I'd suggest to just use that commit then, because functionality wise nothing changed. The problem is that VS 2017 can't handle intrinsics inside of pack expansion so I'd need to copy the parts where intrinsics are used into their own separate function.

[gurachan]

the lastest one almost perfectg but it has

xorstr.hpp(189): fatal error C1001: An internal error has occurred in the compiler.
1>(compiler file 'd:\agent\_work\2\s\src\vctools\compiler\cxxfe\sl\p1\c\yyaction.cpp', line 9294)
1> To work around this problem, try simplifying or changing the program near the locations listed above.

i do use the commit for vs2017 above but its kinda exposed

  qmemcpy(SubStr, "garbagetext", 12);
  *(_DWORD *)&SubStr[12] = -392595922;
  v7.m128i_i64[0] = 0xdeedbeef;
  v7.m128i_i64[1] = 0xdeedbeef;
  *(__m128i *)SubStr = _mm_xor_si128(*(__m128i *)SubStr, v7);
  if ( !strstr(v0, SubStr) )

the latest one kinda pog

 v6.m128i_i64[0] = 0xdeedbeef;
  v6.m128i_i64[1] = 0xdeedbeef;
  v13.m128i_i64[0] = 0xdeedbeef;
  v13.m128i_i64[1] = 0xdeedbeef;
  v6 = _mm_xor_si128(v6, v13);
  if ( sub_100037B0(v0, &v6) )

sadly only works on vs2019