Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate using a smaller package than express #196

Closed
XhmikosR opened this issue Dec 1, 2020 · 2 comments · Fixed by #198
Closed

Investigate using a smaller package than express #196

XhmikosR opened this issue Dec 1, 2020 · 2 comments · Fixed by #198
Assignees
@JustinBeckwith
Labels
enhancement New feature or request released

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Dec 1, 2020

@JustinBeckwith have you thought about an alternative implementation? The express package is a substantial addition, aprox. 25% :/

https://packagephobia.com/result?p=linkinator

Originally posted by @XhmikosR in #188 (comment)
@XhmikosR XhmikosR mentioned this issue Dec 1, 2020
Merged
@JustinBeckwith JustinBeckwith mentioned this issue Dec 2, 2020
Merged
@JustinBeckwith JustinBeckwith added the enhancement New feature or request label Dec 2, 2020
@JustinBeckwith JustinBeckwith self-assigned this Dec 2, 2020
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

🎉 This issue has been resolved in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Dec 2, 2020

Wow, that was really fast, thanks @JustinBeckwith!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove express dependency JustinBeckwith/linkinator
2 participants
@XhmikosR @JustinBeckwith