Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: convert to es modules, drop node 10 #359

Merged
merged 3 commits into from Nov 17, 2021
Merged

feat!: convert to es modules, drop node 10 #359

merged 3 commits into from Nov 17, 2021

Conversation

JustinBeckwith
Copy link
Owner

@JustinBeckwith JustinBeckwith commented Nov 14, 2021

BREAKING CHANGE: this module now requires node.js 12 and above, and has moved to es modules by default.

@JustinBeckwith
Copy link
Owner Author

@bcoe this is super weird. Looks like everything works in node 14 and 16, but only on 12 I am getting:

> c8 mocha build/test


SyntaxError[ @/home/runner/work/linkinator/linkinator/build/test/test.cli.js ]: Unexpected token '?'
    at Loader.moduleStrategy (internal/modules/esm/translators.js:140:18)
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------
npm ERR! Test failed.  See above for more details.
Error: Process completed with exit code 1.

I have no idea how to further debug this since I'm getting no stack trace 🤔 Ideas on who to ask here?

@JustinBeckwith
Copy link
Owner Author

Ok, well that was terrible to figure out. Regardless :) @bcoe could I trouble you for a code review on this one? There are a lot of changes in the ES Modules realm, and I would love a second set of eyes.

@bcoe
Copy link
Contributor

bcoe commented Nov 16, 2021

@JustinBeckwith happy to look 👍

@JustinBeckwith JustinBeckwith changed the title feat!: convert to es modules feat!: convert to es modules, drop node 10 Nov 17, 2021
@JustinBeckwith JustinBeckwith merged commit efee299 into main Nov 17, 2021
@bcoe
Copy link
Contributor

bcoe commented Nov 17, 2021

I'm late to the game, but these changes look right to me.

@github-actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants