Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same broken link in multiple files is being mentioned only once #554

Open
PranjalMaithani opened this issue Jun 14, 2023 · 1 comment
Open

Comments

@PranjalMaithani
Copy link

If I have a common broken link in multiple files, it is only being mentioned once in the output.

Consider this scenario:

pageA has 2 broken links:

/broken123
/broken456

pageB has 2 broken links

/broken123
/broken789

The /broken123 link is a common broken link in the 2 pages. When I run linkinator it is not informing me of /broken123 in pageB

pageA/index.html
[404] broken123
[404] broken456
pageB/index.html
[404] broken789

Minimal repro repo: https://github.com/PranjalMaithani/linkinator-repeated-issue

@sh-ghanique
Copy link

Confirmed. I see the same issue.

As a consequence, taking your example, after fixing broken123 on that page, one would expect the error to be gone. But a new scan will just list it again, but then on a different page. This turn fixing broken links into a whack-a-mole game, making it inefficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants