Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: support Retry-After header #116

Open
sk- opened this issue Jun 19, 2020 · 2 comments
Open

Feature Request: support Retry-After header #116

sk- opened this issue Jun 19, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@sk-
Copy link

sk- commented Jun 19, 2020

is there any change to add support for the Retry-After header (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After).

This is specially useful to deal with quota exceeded errors (429).

Probably an upper bound should be added, so that one doesn't wait forever. In that way is the service is going to be down for a while (503) or if you have no quota left, then the request would fail immediately without even retrying.
@JustinBeckwith JustinBeckwith added the enhancement New feature or request label Jun 19, 2020
@blakeyp
Copy link
Contributor

blakeyp commented Feb 13, 2021

Hey @JustinBeckwith I've made a PR for this feature - #142
Be glad of any thoughts on it :)

@gambrose
Copy link

I see that #142 is merged in.
Can I ask when is this feature going to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustinBeckwith @sk- @gambrose @blakeyp