Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin down thread on disconnect #577

Open
twyatt opened this issue Sep 26, 2023 · 0 comments · May be fixed by #612
Open

Spin down thread on disconnect #577

twyatt opened this issue Sep 26, 2023 · 0 comments · May be fixed by #612
Labels

Comments

@twyatt
Copy link
Member

twyatt commented Sep 26, 2023

Currently, on Android, Kable spins up a dedicated thread for I/O per peripheral. The thread is not spun down until the peripherals scope is cancelled.

This is not intuitive for consumers. Instead, the thread should be spun down on disconnect (or released back to a pool). This will remove the requirement to dispose of the peripheral scope in order to prevent leaking threads.

@twyatt twyatt added the android label Sep 26, 2023
@twyatt twyatt linked a pull request Mar 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant