fix: space should prevent optional argument to \\ #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `src/functions/cr.js`'s definition of `\\` to manually look for an optional argument via `future()` instead of `numOptionalArgs`, so that it does *not* skip over spaces. This matches the existing behavior of `\\` in `src/environments/array.js` and AMSMath's behavior of `\math@cr` via `\new@ifnextchar`. Fixes #3745
Codecov Report
@@ Coverage Diff @@
## main #3746 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 91 91
Lines 6769 6770 +1
Branches 1572 1574 +2
=======================================
+ Hits 6294 6295 +1
Misses 437 437
Partials 38 38
Continue to review full report at Codecov.
|
|
@edemaine Thank for following up on this. |
|
🎉 This PR is included in version 0.16.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
src/functions/cr.js's definition of\\to manually look for an optional argument viafuture()instead ofnumOptionalArgs, so that it does not skip over spaces. This matches the existing behavior of\\insrc/environments/array.jsand AMSMath's behavior of\math@crvia\new@ifnextchar.Fixes #3745; see that for details.