New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to edges with no node check #47
Comments
Hello @andrea-cassioli-maersk! Thank you for showing interest to QuikGraph :-) Oh I see, that's mainly the integrity contrainst that is responsible of this. Do you have some profiling data to share on that topic? Hum something that can be indeed implemented, it would be like an unsafe mode I imagine. Like disable checking producing better performance but user is responsible of maintaining the integrity. Note that this may produce unexpected behaviors in case the constraint is not met, since the whole design of those structures was to ensure logic is not broken at any point. |
Hi @KeRNeLith , |
In this case we can consider what I was talking about an unsafe mode. |
@andrea-cassioli-maersk did you find time to have some profiling data? |
Is your feature request related to a problem? Please describe.
Running some profiling on our application, it seems that adding edges to a bidirectional graph is quite expensive, and in particular quite an amount of time is spent in looking up if origin and destination nodes are valid, i.e. they exists.
Describe the solution you'd like
I was thinking about a flag to disable node existence checking. It could be enable by default, without breaking current interface.
The text was updated successfully, but these errors were encountered: