forked from detekt/detekt
/
UndocumentedPublicFunctionSpec.kt
211 lines (191 loc) · 5.53 KB
/
UndocumentedPublicFunctionSpec.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
package io.gitlab.arturbosch.detekt.rules.documentation
import io.gitlab.arturbosch.detekt.test.TestConfig
import io.gitlab.arturbosch.detekt.test.compileAndLint
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Nested
import org.junit.jupiter.api.Test
private const val SEARCH_PROTECTED_FUN = "searchProtectedFunction"
class UndocumentedPublicFunctionSpec {
val subject = UndocumentedPublicFunction()
@Test
fun `reports undocumented public functions`() {
val code = """
fun noComment1() {}
"""
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `reports undocumented public function in object`() {
val code = """
object Test {
fun noComment1() {}
}
"""
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `reports undocumented public function in nested object`() {
val code = """
class Test {
object Test2 {
fun noComment1() {}
}
}
"""
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `reports undocumented public functions in companion object`() {
val code = """
class Test {
companion object {
fun noComment1() {}
public fun noComment2() {}
}
}
"""
assertThat(subject.compileAndLint(code)).hasSize(2)
}
@Test
fun `reports undocumented public function in an interface`() {
val code = """
interface Test {
fun noComment1()
}
"""
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Test
fun `does not report documented public function`() {
val code = """
/**
* Comment
*/
fun commented1() {}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report documented public function in class`() {
val code = """
class Test {
/**
*
*/
fun commented() {}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report undocumented internal and private function`() {
val code = """
class Test {
internal fun no1(){}
private fun no2(){}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report undocumented nested function`() {
val code = """
/**
* Comment
*/
fun commented() {
fun iDontNeedDoc() {}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report public functions in internal class`() {
val code = """
internal class NoComments {
fun nope1() {}
public fun nope2() {}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report public functions in private class`() {
val code = """
private class NoComments {
fun nope1() {}
public fun nope2() {}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report public functions in private object`() {
val code = """
private object Test {
fun noComment1() {}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report protected functions by default`() {
val code = """
object Test {
protected fun noComment1() {}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `reports protected functions if configured`() {
val code = """
object Test {
protected fun noComment1() {}
}
"""
val subject = UndocumentedPublicFunction(TestConfig(mapOf(SEARCH_PROTECTED_FUN to "true")))
assertThat(subject.compileAndLint(code)).hasSize(1)
}
@Nested
inner class `nested class` {
@Test
fun `does not report public functions in internal interface`() {
val code = """
internal interface Foo {
interface Bar {
fun f() {
}
}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report public functions in private class`() {
val code = """
class Foo {
private class Bar {
class Baz {
fun f() {
}
}
}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
@Test
fun `does not report public functions in private object`() {
val code = """
private object Foo {
class Bar {
fun f() {
}
}
}
"""
assertThat(subject.compileAndLint(code)).isEmpty()
}
}
}