Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document differences from findbugs-slf4j #19

Open
mattnelson opened this issue Nov 1, 2018 · 1 comment
Open

Document differences from findbugs-slf4j #19

mattnelson opened this issue Nov 1, 2018 · 1 comment
Assignees

Comments

@mattnelson
Copy link

The readme calls out

This provides almost same feature with findbugs-slf4j.

I am current using findbugs-slf4j and am wondering if the differences are only the patterns? Will the missing findbugs patterns be ported?

errorprone findbugs
Slf4jPlaceholderMismatch SLF4J_PLACE_HOLDER_MISMATCH
Slf4jFormatShouldBeConst SLF4J_FORMAT_SHOULD_BE_CONST
SLF4J_UNKNOWN_ARRAY
Slf4jLoggerShouldBePrivate SLF4J_LOGGER_SHOULD_BE_PRIVATE
Slf4jLoggerShouldBeFinal SLF4J_LOGGER_SHOULD_BE_FINAL
Slf4jLoggerShouldBeNonStatic SLF4J_LOGGER_SHOULD_BE_NON_STATIC
Slf4jIllegalPassedClass SLF4J_ILLEGAL_PASSED_CLASS
Slf4jSignOnlyFormat SLF4J_SIGN_ONLY_FORMAT
SLF4J_MANUALLY_PROVIDED_MESSAGE

https://github.com/KengoTODA/errorprone-slf4j#supported-bug-patterns
https://github.com/KengoTODA/findbugs-slf4j#provided-bug-patterns

@KengoTODA KengoTODA self-assigned this Jan 4, 2019
KengoTODA added a commit that referenced this issue Feb 15, 2019
KengoTODA added a commit that referenced this issue Mar 3, 2019
@KengoTODA
Copy link
Owner

SLF4J_MANUALLY_PROVIDED_MESSAGE has been implemented in the v0.14.0 release.

I'll reconsider we really need SLF4J_UNKNOWN_ARRAY for errorprone or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants