Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: SLF4J_PARAMETER_TOSTRING #67

Open
vorburger opened this issue Feb 9, 2018 · 2 comments
Open

RFE: SLF4J_PARAMETER_TOSTRING #67

vorburger opened this issue Feb 9, 2018 · 2 comments

Comments

@vorburger
Copy link
Contributor

This is a suggestion for a new validation:

When reviewing code, I regularly see folks doing things such as:

LOG.trace("bla bla: {}", dpid.toString());

where that toString() is wrong of course, and can hurt performance.

It would be nice to automatically get any use of toString() in a parameter flagged up.
@maggu2810
Copy link

Good idea.

@vorburger
Copy link
Contributor Author

@KengoTODA do you have any plans to add this, or would you welcome a PR with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maggu2810 @vorburger