You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// Mocking only one response
$this->addResponse( new EthereumFeeEstimateResponse('0.01', '0.9'));
$this->requestEthereum(new EthereumFeeEstimateRequest('ETH', '199', 'abc', 'address')); // same body
$this->requestEthereum(new EthereumFeeEstimateRequest('ETH', '199', 'abc', 'address')); // same body
$this->shouldMakeCallToTheNetwork(); // Next call should throw "Mock queue is empty"
$this->requestEthereum(new EthereumFeeEstimateRequest('USDT', '199', 'abc', 'address')); // different body.
Expect that the third request will trigger a network call... but instead, it uses cache.
Due to: \Kevinrob\GuzzleCache\Strategy\PrivateCacheStrategy::getCacheKey
All CacheStrategyInterface use the following line to generate cache key $request->getMethod().$request->getUri().json_encode($cacheHeaders). Which does not include request body.
I think for POST request it is fair to add body for cache key as well.
Version: kevinrob/guzzle-cache-middleware v3.5.0
The text was updated successfully, but these errors were encountered:
POST queries should not be cached. POST is an unsafe method and the RFC 7234 ask us to not cache it.
A cache MUST write through requests with methods that are unsafe
(Section 4.2.1 of [RFC7231]) to the origin server; i.e., a cache is
not allowed to generate a reply to such a request before having
forwarded the request and having received a corresponding response.
Test which.
Expect that the third request will trigger a network call... but instead, it uses cache.
Due to:
\Kevinrob\GuzzleCache\Strategy\PrivateCacheStrategy::getCacheKey
All CacheStrategyInterface use the following line to generate cache key
$request->getMethod().$request->getUri().json_encode($cacheHeaders)
. Which does not include request body.I think for POST request it is fair to add body for cache key as well.
Version:
kevinrob/guzzle-cache-middleware v3.5.0
The text was updated successfully, but these errors were encountered: