Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate and add brotli #145

Closed
ManjotS opened this issue Apr 5, 2017 · 12 comments
Closed

Evaluate and add brotli #145

ManjotS opened this issue Apr 5, 2017 · 12 comments

Comments

@ManjotS
Copy link
Contributor

ManjotS commented Apr 5, 2017

https://certsimple.com/blog/nginx-brotli

@bogas04
Copy link
Collaborator

bogas04 commented Nov 6, 2017

In my own research, brotli is great (20% compression improvement over gzip), however its compression time is pathetic, and is meant to be compiled before hand as opposed to compressing on the fly. If we can support that, then we should definitely go for it, as all modern browsers support it.

I can setup our build process to also produce .br files, which can then be sent to CDN, and nginx can be updated to serve it (brotli-static)

@ManjotS
Copy link
Contributor Author

ManjotS commented Nov 6, 2017

this pretty low priority, especially if you aren't confident in it.

@ManjotS ManjotS added the 3️⃣ label Nov 6, 2017
@bogas04
Copy link
Collaborator

bogas04 commented Mar 18, 2018

@navdeepsinghkhalsa What can we do to make this happen? We can produce brotli JS assets at build step (webpack plugin) to begin with.

@navdeepsinghkhalsa
Copy link
Contributor

@bogas04 That's great that you are ready for this at the front-end. Just need to evaluate if it's something we want to do. I will take a look after this sprint closes.

@bogas04
Copy link
Collaborator

bogas04 commented Mar 18, 2018

20% better compression at no cost. Just that we need to pre-build the files.

@bogas04 bogas04 changed the title evaluate and add brotli Evaluate and add brotli Mar 26, 2018
@saintsoldierx
Copy link
Collaborator

@navdeepsinghkhalsa do we still want to do this? please re-assign as needed.

@saintsoldierx
Copy link
Collaborator

This ticket still valid @ManjotS

@ManjotS
Copy link
Contributor Author

ManjotS commented Jun 7, 2020

@tsingh777 please let us know

@saintsoldierx
Copy link
Collaborator

@tsingh777

@saintsoldierx
Copy link
Collaborator

ping @tsingh777

@tsingh777
Copy link
Contributor

Would like to see if expressjs/compression#172 gets accepted. keep it open at low priority.

@gurjit03
Copy link
Collaborator

gurjit03 commented Jun 9, 2024

This needs more discussion/research and might be even avoidable if we opt for next.js or any other framework.

@gurjit03 gurjit03 closed this as completed Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants