Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL_VERTEX_BINDING_BUFFER and GL_VERTEX_ATTRIB_BINDING missing #54

Open
vhirtham opened this issue Dec 17, 2018 · 3 comments · May be fixed by #147
Open

GL_VERTEX_BINDING_BUFFER and GL_VERTEX_ATTRIB_BINDING missing #54

vhirtham opened this issue Dec 17, 2018 · 3 comments · May be fixed by #147

Comments

@vhirtham
Copy link
Contributor

Hello,

during a discussion in the OpenGL forum we discovered that GL_VERTEX_ATTRIB_BINDING is missing in the documentation of glGetVertexAttribiv (link) and GL_VERTEX_BINDING_BUFFER in the documentation of glGetIntegeri_v (link). For what I have seen they are in the specs (Table 23.4 - Page 565 - OpenGL 4.5 specs)

Greetings

@oddhack
Copy link
Contributor

oddhack commented Dec 19, 2018

Thanks for the report @vhirtham - would you be willing and able to propose an MR to the corresponding refpages in this repo? It looks like the problem affects ES as well and goes back to GL 2.1, so probably all the glGetVertexAttrib.xml in the registry would need to be tweaked :-(

@vhirtham
Copy link
Contributor Author

@oddhack I can try :) - I will see what I can do but it has to wait until next week. I will start with the gl4 folder and open a pull request once it is done. If my changes got accepted I can just copy the modifications to the other versions and update the PR.

@vhirtham vhirtham mentioned this issue Jan 8, 2019
oddhack added a commit that referenced this issue Nov 3, 2019
@oddhack
Copy link
Contributor

oddhack commented Nov 3, 2019

I hadn't accepted this because there were some remaining issues, but went ahead and took it now to clear the PR off the table. The remaining issues were, per my original comment on #58:


For the other versions of the refpages, here's what I can see:

  • VERTEX_ATTRIB_ARRAY_BUFFER_BINDING was added in OpenGL 2.0 and ES 2.0, so applies to all the refpage sets except those under 'es1.1/'.
  • VERTEX_ATTRIB_ARRAY_LONG was added in GL 4.3, applies to the 'gl4/' refpages.
  • VERTEX_ATTRIB_RELATIVE_OFFSET and VERTEX_BINDING_BUFFER were added in GL 4.3 and ES 3.1, so apply to the 'gl4/', 'es3/', and 'es3.1/' refpages.

So if you want to make the corresponding updates to the other refpages, that would be appreciated. If not we can just accept this as is, and keep #54 open for future fixes. It is unfortunately tedious to have all these different refpage sets to keep maintained, but rewriting them to do version conditionals in the Docbook source, or to a better source format like asciidoctor, would be an enormous task we don't have resources for right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants