Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token-less login to Github and Kittycad #11

Open
pierremtb opened this issue Mar 2, 2023 · 2 comments
Open

Token-less login to Github and Kittycad #11

pierremtb opened this issue Mar 2, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@pierremtb
Copy link
Collaborator

No description provided.

@pierremtb pierremtb added the enhancement New feature or request label Mar 2, 2023
@pierremtb pierremtb self-assigned this Mar 2, 2023
@pierremtb
Copy link
Collaborator Author

Seems like for KittyCAD, the way to go would be something similar to https://github.com/KittyCAD/cli/blob/main/src/cmd_auth.rs#L117

@pierremtb
Copy link
Collaborator Author

Now questioning the value of this. If I don't make the click-to-login perfect, users might get signed off because a refresh token expired or something that's not transparent at all for them. But the token are long-lived by design, and I think the direct links make the experience a good-enough compromise

@pierremtb pierremtb added the question Further information is requested label Jul 11, 2023
@KittyCAD KittyCAD deleted a comment from org-projects-app bot Sep 18, 2023
@KittyCAD KittyCAD deleted a comment from org-projects-app bot Sep 18, 2023
@KittyCAD KittyCAD deleted a comment from org-projects-app bot Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant