Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch is_safe_to_batch logic is bad #273

Open
jessfraz opened this issue Mar 23, 2024 · 1 comment
Open

batch is_safe_to_batch logic is bad #273

jessfraz opened this issue Mar 23, 2024 · 1 comment

Comments

@jessfraz
Copy link
Contributor

this should just auto include anything with a empty response

pub fn is_safe_to_batch(&self) -> bool {

@jessfraz
Copy link
Contributor Author

if we get it to autopopulate those with empty responses we could use this in the modeling app versus this hardcoded shit https://github.com/KittyCAD/modeling-app/pull/1871/files#diff-5f06b28afb57092ba5305159f4fbf8e1bf2bf9f77040635a03141e5690893034R99

otherwise we should just delete this function as it is dead code and no longer used anuywhere

cc @lf94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant