Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show loader or something while engine is doing the export #2305

Open
jessfraz opened this issue May 6, 2024 · 2 comments
Open

show loader or something while engine is doing the export #2305

jessfraz opened this issue May 6, 2024 · 2 comments
Assignees
Labels
bug Something isn't working design Design related issues high priority

Comments

@jessfraz
Copy link
Contributor

jessfraz commented May 6, 2024

not an essential priority but we will want for v1 since its confusing

Screenshare.-.2024-05-06.12_48_45.PM.mp4
@franknoirot
Copy link
Collaborator

Yahp you're totally right. I want to think about if we should make the command palette have a loading state, or instead do like a loading toast using toast.promise() on the Export command or something. I have a hunch that the toast approach will be easier.

@franknoirot franknoirot added the design Design related issues label May 14, 2024
@franknoirot
Copy link
Collaborator

@jessfraz I looked into this today and ran into a little something trying to pass back the Promise of the success/failure/cancellation of the save dialog.

Basically with modeling commands we use this command.resolve to resolve the pending promise, but we don't seem to do the same with Export; here we just void the resolution of exportSave.

I'm a little unfamiliar with the artifactMap workings, but I think I need to find the export command by ID and wire up the return value of exportSave to either its .promise or .resolve

@jessfraz jessfraz added bug Something isn't working high priority labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design Design related issues high priority
Projects
None yet
Development

No branches or pull requests

2 participants