Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align dependencies URLs #1559

Open
tomerd opened this issue Sep 20, 2021 · 1 comment
Open

align dependencies URLs #1559

tomerd opened this issue Sep 20, 2021 · 1 comment

Comments

@tomerd
Copy link

tomerd commented Sep 20, 2021

Hi folks,

In a recent update to SwiftPM we improved the validation of dependencies with different URLs. Specifically, we now check more accurately when two packages are named similarly but have different source git URLs. We originally made this into an error since it can yield undefined behavior, but later relaxed it to a warning since the Kitura project suffers from this setup which showed up in our source compatibility test suite: https://bugs.swift.org/browse/SR-15146

For Kitura specifically, there seems to be a mix of URLs from the original IBM GitHub organization and the current Kitura GitHub organization, which I assume stems from the fact the repos were moved from one org to the other but the dependencies on various Package.swift files still point to the IBM org. While in this case the repos are literally the same (redirect at GitHub level), SwiftPM has no way to reconcile the URL differences as it operates at the git level and cannot be aware of Github logic / redirects, and different URLs could also mean totally different sources.

To resolve this, please update all Package.swift files to use the Kitura org URLs.

Feel free to reach out with any questions.
--Tom

cc @abertelrud @neonichu

@mbarnach
Copy link
Member

@tomerd Thanks for the feedback. This is in process, hopefully solved soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants