Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run commit ignores body message #1774

Closed
finetjul opened this issue Mar 10, 2021 · 4 comments
Closed

npm run commit ignores body message #1774

finetjul opened this issue Mar 10, 2021 · 4 comments
Assignees

Comments

@finetjul
Copy link
Member

Using npm run commit
I first enter no long description. But then I say it affects open issue, it requires long description.
The texted entered then never ends up in the commit body:

$npm run commit
? Select the type of change that you're committing: feat:     A new feature
? What is the scope of this change (e.g. component or file name): (press enter to skip) foo
? Write a short, imperative tense description of the change (max 89 chars):
 (7) add foo
? Provide a longer description of the change: (press enter to skip)

? Are there any breaking changes? No
? Does this change affect any open issues? Yes
? If issues are closed, the commit requires a body. Please enter a longer description of the commit itself:
 My very long description will never go into the commit body
? Add issue references (e.g. "fix #123", "re #123".):
 fix #123

Content of the commit

$ git log -1
commit e5912a16763fce65f2fc50a94abfe29ae14d87f6 (HEAD -> 123-foo)
Author: Julien Finet <julien.finet@kitware.com>
Date:   Wed Mar 10 17:28:51 2021 +0100

    feat(foo): add foo

    fix #123

Where is "My very long description will never go into the commit body"?
I'm on windows if that makes a difference.

@jourdain
Copy link
Collaborator

Why didn't you provide it at Provide a longer description of the change:?

@finetjul
Copy link
Member Author

I did not think it was deserving a longer description. I guess this is not really the issue here. Or said differently, yes, there is a work-around (i.e. specify a longer description at Provide a longer description of the change:).

@jourdain
Copy link
Collaborator

My understanding was that commitizen was telling you that you should have provided a longer description, but it was not really asking for anything at that time (too late).

If you think that is an issue, you should post it on the commitizen project directly.

@finetjul
Copy link
Member Author

Already tracked: commitizen/cz-cli#779
About to be fixed: commitizen/cz-conventional-changelog#132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants