Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] After Chrome version bump to 113 with WebGPU support, vtk.js render edge error #2819

Closed
supriome opened this issue May 6, 2023 · 6 comments
Labels
type: bug 🐞 Errors in functionality

Comments

@supriome
Copy link

supriome commented May 6, 2023

Bug description

vtk.js support webgpu if browser support webgpu, and when chrome v113 start support WebGPU by default, vtk.js render edge with some problem, you can see the line was been broken, and you can't change different render mode, if you switch mode Surface with Surface with Edge, you can't switch back. A error show Uncaught TypeError: Cannot read properties of null (reading 'getRenderable') because WebGPUActor.getRenderable() not exsit. Then your app is broken.

image

image

Steps to reproduce

Upgrade Chrome to version 113, and then go to the GeometryViewer example.

Detailed Behavior

No response

Expected Behavior

You can manually choose whether to support WebGPU feature.

Environment

  • vtk.js version: 27.4.1
  • Browsers: Chrome v113
  • OS: MacOS and Windows
@supriome supriome added the type: bug 🐞 Errors in functionality label May 6, 2023
@supriome
Copy link
Author

supriome commented May 6, 2023

I notice that you can manually set viewAPI to 'WebGL' by renderWindow.setDefaultViewAPI('WebGL'), and I try this in my local machine by running GeometryViewer example, it's true that now I use WebGL Renderwindow, but the edge still show with error, it should be continuous straight line rather than dashed.

image

image

@floryst
Copy link
Collaborator

floryst commented May 8, 2023

This is now fixed in v27.4.2 by defaulting to WebGL until the WebGPU implementation is stable. The fix will be backported shortly

@floryst floryst closed this as completed May 8, 2023
@floryst
Copy link
Collaborator

floryst commented May 8, 2023

Actually, I'll leave this issue open until the backport is complete.

@floryst floryst reopened this May 8, 2023
@mengxiao-ac
Copy link

In our actual application development, we found an error when upgrading Google Chrome to version 113. We hope the development team can pay attention to this issue.
飞书20230511-104246

@floryst
Copy link
Collaborator

floryst commented May 11, 2023 via email

@floryst
Copy link
Collaborator

floryst commented May 30, 2024

Closing as completed.

@floryst floryst closed this as completed May 30, 2024
@floryst floryst unpinned this issue May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐞 Errors in functionality
Projects
None yet
Development

No branches or pull requests

3 participants