Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): fix type returned when inserting a point #3049

Merged
merged 1 commit into from
May 30, 2024

Conversation

ramonemiliani93
Copy link
Contributor

Fix #3048

Context

Fixes the interface of the insertNextPoint method on the vtkPoints class.

Results

Updates the interface on the Points.d.ts file.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

ramonemiliani93 pushed a commit to ramonemiliani93/vtk-js that referenced this pull request Mar 27, 2024
@ramonemiliani93 ramonemiliani93 force-pushed the fix_points_interface branch 2 times, most recently from 69ebc9d to d2628dd Compare March 27, 2024 20:58
Sources/Common/Core/Points/index.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks !

Copy link
Collaborator

@daker daker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue May 30, 2024
Merged via the queue into Kitware:master with commit 952a26f May 30, 2024
3 checks passed
Copy link

🎉 This PR is included in version 30.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect interface for insertNextPoint on vtkPoints
4 participants