Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trash-rs as optional feature #18

Closed
0323pin opened this issue Sep 15, 2022 · 9 comments
Closed

trash-rs as optional feature #18

0323pin opened this issue Sep 15, 2022 · 9 comments

Comments

@0323pin
Copy link
Contributor

0323pin commented Sep 15, 2022

Hi,

NetBSD/pkgsrc maintainer here.
Aiming at packaging simp for NetBSD, would it be possible to make trash an optional feature?
trash-rs does not build on NetBSD, see Byron/trash-rs#56 for details.

Regards

@Kl4rry
Copy link
Owner

Kl4rry commented Sep 15, 2022

Yes I can make trash-rs an optional dependency.

@0323pin
Copy link
Contributor Author

0323pin commented Sep 15, 2022

Great, thanks!
I'll wait for it and give it another go at packaging.

@Kl4rry Kl4rry closed this as completed in ae385db Sep 16, 2022
@0323pin
Copy link
Contributor Author

0323pin commented Sep 16, 2022

Tack. Återkommer när jag har haft tid att testa det.

@0323pin
Copy link
Contributor Author

0323pin commented Sep 16, 2022

All good! Tack!

http://mail-index.netbsd.org/pkgsrc-wip-changes/2022/09/16/msg024970.html

2022-09-16-192003_1366x768_scrot

Will import the package once the commit freeze due to branching is over.

@0323pin
Copy link
Contributor Author

0323pin commented Dec 21, 2022

@Kl4rry Hej! Insåg att 3.3.1 fanns i crates.io men det finns ingen tag här i Github.
Jag har nu byggt den lokalt och allt fungerar bra. Men, just nu har vi en freeze inför stable branch release. Vet du om den bygger med rust-1.64? Om ja, kan jag pusha den idag så den hinner med innan release

Jag undrar också om det är möjligt att hålla Github och crates.io i sync. Jag använder nämligen RSS feeds från Github för att tracka mina paket.

Tack, och trevlig jul.

@Kl4rry
Copy link
Owner

Kl4rry commented Dec 21, 2022

@0323pin I forgot 💀 to upload to github. Do you know if it possible to automate it with github actions? It is not possible to build because epaint a egui dependency requires 1.65 är newer.

Go jul

@0323pin
Copy link
Contributor Author

0323pin commented Dec 21, 2022

Do you know if it possible to automate it with github actions?

Should be, I've asked for this before in other projects but, I'm not a github expert.

epaint a egui dependency requires 1.65

Thanks! I need to leave it until after the branch freeze, then. Rust-1.65 should be merged shortly after, I hope. I'm running 1.66 myself and sometimes (it happens), I merge things that have to be reverted.

@0323pin
Copy link
Contributor Author

0323pin commented Sep 27, 2023

@Kl4rry FYI, rust-lang/libc#3368

@0323pin
Copy link
Contributor Author

0323pin commented Oct 8, 2023

@Kl4rry Hi! Combining libc-0.2.149 and trash-rs-3.1.0 allows the trash feature to build and function on NetBSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants