-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing RSpec tests on ~>7.0.0 #246
Comments
I'm seeing the same issue with e.g/
Just in case it's not obvious, the instance method does exist :) |
Could you prepare an integration test like this one to help us reproduce an issue? Or it could be a new Rails app that we could use to debug it? Thank you. |
Hi @ArturT do you mean something like https://github.com/KnapsackPro/knapsack_pro-ruby/pull/247/files ? |
@GeoffTidey Yes. I've run this test and it's passing successful.
We need to prepare a test that would fail with the same error as you see in your project. Then we could prepare a fix for that. Are you able to identify what is causing the error in your project? |
Afraid not. It's intermittent. |
I use the following loop to run test as long until it fails but it is successful. I'm not able to reproduce the issue. while bundle exec rspec "spec/integration/runners/queue/rspec_runner_spec.rb:382"; do :; done I use ruby 3.2.3 (2024-01-18 revision 52bb2ac0a6) [arm64-darwin22]. I tried to reproduce it on an older RSpec version without success:
I also tried to use the latest gems, but I'm not able to reproduce the issue:
@GeoffTidey Could you provide your Ruby and dependency versions? It will help pinpoint what differs between our setups. |
Hi @ArturT , sorry for the radio silence. It's not been happening at all since my last update. Two things have changed, the first is probably the issue:
|
I am setting up Knapsack Pro with gem version 7.0.0 and 7.0.1. Tests are failing with both the versions which otherwise is passing.
I am mostly getting two types of error which relates to
instance_double
tests and materialize-view dependent tests. Following is the error description from the runsOther error:
I am trying to set it up on Github Actions with VCR/WebMosck setup. All of these tests are passing when I try it with 6.0.4.
Following is the command that I'm using to invoke the test in GHA runner
bundle exec rake "knapsack_pro:queue:rspec[--require packs/rails/rspec --require spec_helper --order rand --require fivemat --format Fivemat --format RSpec::Github::Formatter --format RspecJunitFormatter --out report/ruby-rspec-${{ matrix.node_index }}.xml]"
The text was updated successfully, but these errors were encountered: