Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require guzzle explicitly #91

Open
GuySartorelli opened this issue Dec 3, 2023 · 5 comments · May be fixed by #99
Open

Don't require guzzle explicitly #91

GuySartorelli opened this issue Dec 3, 2023 · 5 comments · May be fixed by #99
Labels
enhancement

Comments

@GuySartorelli
Copy link
Contributor

Some of your other packages, such as https://github.com/KnpLabs/php-github-api, don't explicitly require guzzle - but instead rely on php-http/discovery to find an appropriate PSR7 compliant library.

It would be great if this library was similarly flexible. If you're open to it, I'd be happy to implement that change here.

Note

Possible duplicate of #49 but there's so little information in that issue I couldn't tell.
@robbieaverill
Copy link
Collaborator

robbieaverill commented Dec 3, 2023 •
edited

Having an abstraction for the HTTP client makes sense, to me. If you'd be keen to contribute the changes required I'd be happy to review them.

@GrahamCampbell
Copy link
Contributor

This is a duplicate of #49, as you say.

@GuySartorelli
Copy link
Contributor Author

This is a duplicate of #49, as you say.

If that's the case, I'd recommend closing #49 as it doesn't have much information in it.

@GuySartorelli
Copy link
Contributor Author

If you'd be keen to contribute the changes required I'd be happy to review them.

Awesome, I'll give that a crack sometime in the next few weeks, schedule permitting.

@robbieaverill robbieaverill mentioned this issue Dec 4, 2023
Closed
@GuySartorelli GuySartorelli linked a pull request Dec 14, 2023 that will close this issue
Open
@GuySartorelli
Copy link
Contributor Author

PR raised: #99
Note that I need some guidance on how to update the tests.

@tacman tacman mentioned this issue Feb 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Guzzle with generic PSR18 discovery GuySartorelli/packagist-api
3 participants
@GrahamCampbell @robbieaverill @GuySartorelli