{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":5885483,"defaultBranch":"main","name":"Koha","ownerLogin":"Koha-Community","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-09-20T11:29:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/592086?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716890379.0","currentOid":""},"activityList":{"items":[{"before":"a7959a7d3004a9ac340b39c11181c93ab843f65d","after":"822d7f43ab7437ce6f82108260f73e165db4b374","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:56:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36792: Limit POSIX imports\n\nA Marcel's QA patch to Bug 36552 added use POSIX; in two spots.\nIn https://metacpan.org/pod/POSIX we read:\n\nCAVEATS\nEverything is exported by default (with a handful of exceptions). This is\nan unfortunate backwards compatibility feature and its use is strongly\ndiscouraged. You should either prevent the exporting (by saying use\nPOSIX ();, as usual) and then use fully qualified names (e.g.\nPOSIX::SEEK_END), or give an explicit import list. If you\ndo neither and opt for the default (as in use POSIX;), you will\nimport hundreds and hundreds of symbols into your namespace.\n\nThis patch fixes this.\n\nNo test plan.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 8d9ccd6fc371877fbd4d016ee3bc1de54721787e)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit ca023b334cc9b79cfd85e6bb9a75c7037ae1fd95)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36792: Limit POSIX imports"}},{"before":"5141dbe562062ea185d43ddf9c3b1f488dca03d1","after":"a7959a7d3004a9ac340b39c11181c93ab843f65d","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:38:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 34263: (QA follow-up): Use flatpickr .clear instead\n\nSigned-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>\nSigned-off-by: Nick Clemens <nick@bywatersolutions.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 1137793e44ce6b5d2a4e7759e46218f6ddeb9e8b)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit dcddcda37d1efb586cb75a89df4ad6af0bf438ee)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 34263: (QA follow-up): Use flatpickr .clear instead"}},{"before":"02f57e92b99778ea83dfa78617b302fed43a5af5","after":"5141dbe562062ea185d43ddf9c3b1f488dca03d1","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:37:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36939: Remove a warning from Serials.t\n\nt/db_dependent/Serials.t .. 2/57 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Serials.pm line 2029.\n\nSigned-off-by: David Nind <david@davidnind.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 7d75ec3e2602dcadbb238dfb7cbec76020ebafef)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit f41e7398857cc9f76c0bcdf01e3426c192e773e0)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36939: Remove a warning from Serials.t"}},{"before":"80c86b6f218c3ee49ad0c251f21f4bd0480cfbfb","after":"02f57e92b99778ea83dfa78617b302fed43a5af5","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:36:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36923: Remove warnings from Holds/LocalHoldsPriority.t\n\nt/db_dependent/Holds/LocalHoldsPriority.t .. 1/7 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.\nt/db_dependent/Holds/LocalHoldsPriority.t .. 2/7 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.\nUse of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.\nUse of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.\nt/db_dependent/Holds/LocalHoldsPriority.t .. 5/7 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.\nt/db_dependent/Holds/LocalHoldsPriority.t .. ok\nAll tests successful.\n\nWe didn't have the default values generated by the DBMS\n\nSigned-off-by: David Nind <david@davidnind.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 6827c9061ffc57c2e1f7087aced8ce2e65196558)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 233e92f8996958e66363557daec1859a4f76c93b)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36923: Remove warnings from Holds/LocalHoldsPriority.t"}},{"before":"9ef0f69bb2664496370ef27b874eb3855bf98805","after":"80c86b6f218c3ee49ad0c251f21f4bd0480cfbfb","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:33:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36589: Advanced cataloging - restore the correct height of the clipboard\n\nA simple direct fix for the height of the advanced editor's clipboard,\nwhich is a <select size=\"10\"> that's currently cut down to the height of\none thick line by CSS intended for non-multiple, non-sized selects with\ndropdown menus.\n\nTest plan:\n1. Set the pref EnableAdvancedCatalogingEditor to Enable\n2. Cataloging -> Advanced editor\n3. Note the Clipboard is a single line tall\n4. Apply patch, shift+reload Advanced editor\n5. Note the Clipboard is ten lines tall\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\nSigned-off-by: Nick Clemens <nick@bywatersolutions.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 10a8dc5108dc58d91786ead95f5130a7a147d5b1)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 0413d06b0e0f9e2bb8ec3bf26a55d445a7df7119)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36589: Advanced cataloging - restore the correct height of the cl…"}},{"before":"d2b89534bfdb68d7ccdcc270747aac78cf5b130a","after":"9ef0f69bb2664496370ef27b874eb3855bf98805","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:31:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36943: (follow-up) 24.05.00 - Update .mailmap\n\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit f044310808bd26fb856ed26e78290f972889a9cc)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 57ec82f6e86a230a6ace571e7c5e54e8ddf702fc)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36943: (follow-up) 24.05.00 - Update .mailmap"}},{"before":"855a6a0a130c3bee64c214e8bcfeb8f97bd22786","after":"d2b89534bfdb68d7ccdcc270747aac78cf5b130a","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:30:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36943: 24.05.00 - Update .mailmap\n\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit d8863160da07c81b0b7356c8b923737b401db481)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 6c89d4eeb6348683d32a1928a2e410e3f81c44fe)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36943: 24.05.00 - Update .mailmap"}},{"before":"e93de54ab2c6d96dbd63f2b910e422f350b621b3","after":"855a6a0a130c3bee64c214e8bcfeb8f97bd22786","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:28:19.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36908: (Rmaint follow-up) Fix number of tests\n\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36908: (Rmaint follow-up) Fix number of tests"}},{"before":"a96e7935e59272e83fcd327a3abb3b20ed816efc","after":"e93de54ab2c6d96dbd63f2b910e422f350b621b3","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T15:17:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36924: Remove warning \"Value not allowed for auto_incr itemnumber in Item\"\n\nWe are removing entirely the badly written test.\n\nSigned-off-by: David Nind <david@davidnind.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nNote: We cannot test this properly when the search index refers to biblios\nand items that do not exist in the database.\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 12511385289b41c3c3d067f1b7c4397010e3d27c)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 98fa5f6b25360e056dac72a776e880ec2c4d4970)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36924: Remove warning \"Value not allowed for auto_incr itemnumber…"}},{"before":"8afa23781d232ccc747c3f5e225ca7aa4d494b6f","after":"a96e7935e59272e83fcd327a3abb3b20ed816efc","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T14:40:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36665: (RMaint follow-up) adapt unit test\n\n(cherry picked from commit 8ddb0797f66168765c80df8372a588e1885ff21c)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36665: (RMaint follow-up) adapt unit test"}},{"before":"8e24ce12059ef8f78918aa54d1917913552783ba","after":"8afa23781d232ccc747c3f5e225ca7aa4d494b6f","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T14:39:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36665: (follow-up) Default preference to enabled\n\nWhile this is a new preference, this was the standard behavior for a long time. I think we should\ndefault to enabled to restore previous behavior.\n\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit e48e3d02f301ecf9402812120ca333c91d84d5c5)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit a479192e6745e6f452c0f2b08ce0ff473f19135c)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36665: (follow-up) Default preference to enabled"}},{"before":"1a42d81247bc0bde9542b2bd2574a6a863c23a62","after":"8e24ce12059ef8f78918aa54d1917913552783ba","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T14:35:54.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36665: DBRev 23.05.11.002\n\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36665: DBRev 23.05.11.002"}},{"before":"b16e2059a94cf8f803c5687460e73ccf6c85a5f0","after":"7e246f09750d00a7b0fc6464207e81e7b1f1d5f5","ref":"refs/heads/main","pushedAt":"2024-05-31T14:31:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"DBRev 24.06.00.000: Start of a new release cycle\n\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>","shortMessageHtmlLink":"DBRev 24.06.00.000: Start of a new release cycle"}},{"before":"55492d6bbc0cfe8117344327f35d7d8a48c4bdfa","after":"1a42d81247bc0bde9542b2bd2574a6a863c23a62","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:21:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36858: Remove warnings\n\nArgument \"\" isn't numeric in int\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 678e3f6e208ed47820132215806519f5162545fb)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 4c4349dbdb1ce156320909d5f9527d2206a80c9e)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36858: Remove warnings"}},{"before":"6104cb3c08d7c789e8c81723e9d27335fefcfe1b","after":"55492d6bbc0cfe8117344327f35d7d8a48c4bdfa","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:20:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36914: Remove DBIC warning in shelves.pl\n\nSame fix as Bug 28561: Remove DBIC warning in opac-shelves\nBut for staff\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit f388b99af044be538b62c9e850e341cad064ab95)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 509fd15d26a7c84563c73c12538aea54ee7c078e)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36914: Remove DBIC warning in shelves.pl"}},{"before":"ce48510c21ed1786215d6df782fac4c647b7a215","after":"6104cb3c08d7c789e8c81723e9d27335fefcfe1b","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:18:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 35929: Remove extra parenthesis\n\nand make it more readable\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit ad41c672a13f8e18ea2fbbc4ad3245165693c339)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit ae53cf4eea2fb401bae6fad487b779002aa05789)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 35929: Remove extra parenthesis"}},{"before":"7494d7a032fa38013d7a95d92e54f808bd8bd3c5","after":"ce48510c21ed1786215d6df782fac4c647b7a215","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:16:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36845: Do not loop over the content attribute\n\nWe skip it.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 68e317bd0f8daf967a8af540056e8637524e5d3b)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit aed7e0849634a70880fa09029d018cd053cd9fac)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36845: Do not loop over the content attribute"}},{"before":"d2bb68a9d55abca105a5f95e8805fc978522f6b7","after":"7494d7a032fa38013d7a95d92e54f808bd8bd3c5","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:15:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36892: Fix label for 'is_standing' input\n\nTest plan:\n\n1) Go to acqui/histsearch.pl and look for \"search_children_too\" with\n   dev tools console.\n2) On 'is_standing' input, the same label is used\n3) Apply this patch and reload it\n4) Now it's correct\n\nSponsored by: BibLibre\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\nSigned-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 40900343673c280d092de9c57399a77c113b41ba)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit dacd7fabbe318ad3c340dd5cc1d35b2e67c040d8)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36892: Fix label for 'is_standing' input"}},{"before":"e16fea9ec5e3c46c68490ba4ebbb81e4ba187ede","after":"d2bb68a9d55abca105a5f95e8805fc978522f6b7","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:14:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36856: Fix MARC subfield name in new order from existing bibliographic record\n\nIn form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown.\nThe template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'.\n\nTest plan:\n1) Be sure to have an ACQ biblio framework\n2) Enable system preference UseACQFrameworkForBiblioRecords\n3) Go to an acquisition basket\n4) Add a term in 'From an existing record' and submit\n5) On first result click on 'Add order'\n6) Look at 'Catalog details'\n=> Without patch you only see subfield tag and letter : (123a)\n=> With patch you also see subfield name : Name (123a)\n\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>\nSigned-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 5080eecc2268c2b7b88856800e728041c2fc29ec)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 33370ea55b34b234d8d0f05e84dd03dc5d4313aa)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36856: Fix MARC subfield name in new order from existing bibliogr…"}},{"before":"6d226640b1c9c6541ac2aed4180d5692ab14e2f1","after":"e16fea9ec5e3c46c68490ba4ebbb81e4ba187ede","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:11:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36834: (Bug 29697 follow-up) Koha explodes when trying to open in Labeled MARC view a bibliographic record with an invalid biblionumber\n\nAfter changes made in catalogue/labeledMARCdetail.pl with the bug 29697\nwhen trying to open the Labeled MARC view with\nbiblionumber=<invalid_number> (e.g. a deleted biblionumber) Koha explodes\nwith a message << Can't call method \"metadata\" on an undefined value at\n/kohadevbox/koha/catalogue/labeledMARCdetail.pl line 59 >>\n\nTest plan:\n==========\n1. Activate the viewLabeledMARC syspref.\n2. Try to open a biblio record in Labeled MARC view, giving as a biblionumber\n   (in URL) a non-existing biblionumber, e.g. in ktd, with standard ktd\n   test data:\n   http://your_ktd:8081/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=1234567\n   Koha should explode with the message:\n   Can't call method \"metadata\" on an undefined value at\n   /kohadevbox/koha/catalogue/labeledMARCdetail.pl line 59\n3. Apply the patch; restart_all.\n4. Repeat p. 2.  You should get a regular page with the info \"The record you\n   requested does not exist (1234567)\".\n\nSigned-off-by: Roman Dolny <roman.dolny@jezuici.pl>\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit e4e54af0e77a01d8ad1ee6ac84f5b255951f1831)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 944f3ffc8f0f59b2080d0670f4691a2343413e50)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36834: (Bug 29697 follow-up) Koha explodes when trying to open in…"}},{"before":"22061c248fa01eec5dc92eb47d89d7cd0d96d278","after":"6d226640b1c9c6541ac2aed4180d5692ab14e2f1","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:08:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36872: Untranslatable strings in request.tt\n\nThere are errors in the JavaScript in the holds template in the staff\nclient which results in strings not being translatable. This patch\ncorrects the errors.\n\nTo test, apply the patch and run through the process of placing a hold\non multiple items in the staff interface.\n\n- At the hold confirmation step, try to submit the form without\n  selecting pickup locations for one or more titles.\n- You should get an alert, \"Please make sure all selected titles have a\n  pickup location set\".\n- Uncheck the checkboxes next to each title you're placing a hold on.\n- Submit the form. You should get an error: \"Please select at least one\n  title\".\n\n- Test the translation process with a language, e.g. fr-FR:\n- In KTD, run: gulp po:update --lang fr-FR\n- Check fr-FR-staff-prog.po for the line referring to\n  koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:1499\n- You should see the string \"Please make sure all selected titles have a\n  pickup location set\".\n\nSigned-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 537c960777f94cf964c757ed2773f330612ae3c7)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 4a51f8ca4ae772d5b3f9f06605aa72980ef49a19)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36872: Untranslatable strings in request.tt"}},{"before":"d310549dae5fe2d3688b3f6d90a63c7f101e1fca","after":"22061c248fa01eec5dc92eb47d89d7cd0d96d278","ref":"refs/heads/23.05.x","pushedAt":"2024-05-31T13:06:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36529: manage_additional_fields permission for more than acquisitions and serials\n\nThis patch renames the manage_additional_fields permission to remove\nthe specificity of acquisitions orders and serial subscriptions.\nSince each additional field requires a corresponding permission, I\nwrote each of them next to it. It makes it very long, but right now\nthere isn't really a way to link permissions other than the permission\ndescription.\n\nTo test:\n1. Apply patch\n2. Go to a patron account\n3. Click More > Set permissions\n4. Go to the Administration panel permissions and open the\n   sub-permissions\n5. Check that the manage_additional_fields permission description\n   makes sense, check grammar and spelling, try the various\n   combinations\n\nSigned-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit e251212ff5f783ff7d5d9de3821510ba7928d95f)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit fd982c027ddf247e441f2db278145b54f7dc537c)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36529: manage_additional_fields permission for more than acquisit…"}},{"before":"f41e7398857cc9f76c0bcdf01e3426c192e773e0","after":"dcddcda37d1efb586cb75a89df4ad6af0bf438ee","ref":"refs/heads/23.11.x","pushedAt":"2024-05-31T08:08:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 34263: (QA follow-up): Use flatpickr .clear instead\n\nSigned-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>\nSigned-off-by: Nick Clemens <nick@bywatersolutions.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 1137793e44ce6b5d2a4e7759e46218f6ddeb9e8b)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>","shortMessageHtmlLink":"Bug 34263: (QA follow-up): Use flatpickr .clear instead"}},{"before":"4260a97d6b26d96c1c4b9e748291c5eed6b4891d","after":"d310549dae5fe2d3688b3f6d90a63c7f101e1fca","ref":"refs/heads/23.05.x","pushedAt":"2024-05-30T19:48:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36793: Fix case of $var in Context->delete_preference\n\nThis only applies to 'local' preferences.\n\nTest plan (first without this patch):\nAdd a local pref. Delete it. Ask value on commandline with:\n* perl -MC4::Context -e\"print C4::Context->preference('YOUR_PREF')\"\n* Did you replace YOUR_PREF :)\n\nNow repeat with this patch. And verify fix (no value now).\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 8ea126b1f89e24a2baf8c43f7bf837bf74741088)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 6122b60194af5b6939a6bbae6bc3c7973835b309)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36793: Fix case of $var in Context-&gt;delete_preference"}},{"before":"63c5e96c8bd45498c987963ae9ff41c500a40f04","after":"4260a97d6b26d96c1c4b9e748291c5eed6b4891d","ref":"refs/heads/23.05.x","pushedAt":"2024-05-30T19:45:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36619: Restore 'Columns' visibility on the patron search when placing a hold\n\nTest plan:\nGo to /cgi-bin/koha/reserve/request.pl?biblionumber=117\nSearch for \"d\"\nNotice that with this patch applied the \"Columns\" button is back and\nthat the \"Configure\" is working correctly\n\nSigned-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 76ebbb4b9b3a39c6e7ffffe8ad1b9b2c603daf5c)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit b485b949f4207ffa7b8651858ba4850557734042)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36619: Restore 'Columns' visibility on the patron search when pla…"}},{"before":"7a926a8c28430d14b4f8b423d8458a7c3556b3c2","after":"63c5e96c8bd45498c987963ae9ff41c500a40f04","ref":"refs/heads/23.05.x","pushedAt":"2024-05-30T19:43:59.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 35961: (follow-up) Pass along the borrowernumber\n\nTo test:\n1. APPLY PATCH\n2. Turn on  OpacCatalogConcerns\n3. Find a record and go to the OPAC detail page.\n4. Click \"Report a concern\" in the right navigation menu\n5. Make sure it works\n6. Repeat the proces from MARC view and ISBD view pages\n\nSigned-off-by: David Nind <david@davidnind.com>\nSigned-off-by: Nick Clemens <nick@bywatersolutions.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit e412a4387c888816cf478d811a559c5f57f7e9e2)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit dc8fb79cf4438f31cf72942caccf4a7d6c9bd665)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 35961: (follow-up) Pass along the borrowernumber"}},{"before":"c22b748bab6a653138bdc779a01a0f6f7f14af01","after":"7a926a8c28430d14b4f8b423d8458a7c3556b3c2","ref":"refs/heads/23.05.x","pushedAt":"2024-05-30T19:30:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 33099: Add missing MARC21 Match authority mappings so \"Search all headings\" search works\n\nThe main entry form of corporate names (110), uniform titles (130), topical\nterms (150), geographical names (151), and genre/form (155) are not indexed\nwith 'Match' search field in Elasticsearch standard mapping.  As a result,\nthe respective records are not present on the result list when performing\nan 'All headings' search for the authority records with the main heading form\n(MARC 21).\n\nTest plan\n=========\n0. Have a test installation with Elasticsearch.\n1. In Authorities, make an 'All headings' search for a main entry\n   form from the corporate names, uniform titles, topical terms,\n   geographical names, or genre/form\n   --> e.g., in ktd: UK Archiving.  You will get no results.\n2. Apply the patch, reindex with:\n   sudo koha-elasticsearch --rebuild -r -a kohadev\n3. Repeat the test. You should see 'UK Archiving' on the result list.\n\nSigned-off-by: Roman Dolny <roman.dolny@jezuici.pl>\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit d4c70f7d07dcc0fe1319b6e0380abcd1b7400b95)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 5e405a29a8b5af3daf8c51f814844086d828e63a)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 33099: Add missing MARC21 Match authority mappings so \"Search all…"}},{"before":"c1879aeab49634b6888d99e52eac215256a56b4b","after":"c22b748bab6a653138bdc779a01a0f6f7f14af01","ref":"refs/heads/23.05.x","pushedAt":"2024-05-30T19:28:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly\n\nWe can get into a scenario what a user cannot stay logged in for more than a single page load.\nIf AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load.\n\nTest Plan:\n1) Set your branch ip to a space\n2) Enable AutoLocation\n3) Restart all the things!\n4) Log out\n5) Log in\n6) Browse to another page\n7) You are logged out\n8) Apply patch\n9) Repeat 1-6\n10) You are not logged out!\n\nSigned-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit 7291a312332e4fac7ac61288f33a001d4a7b306c)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit d3dd7d20f1eae2bed24bb6833d08b4c80b4a250f)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36378: Cannot stay logged in if AutoLocation is enabled but branc…"}},{"before":"551248240b6315592bde25219a9b65798513fb25","after":"c1879aeab49634b6888d99e52eac215256a56b4b","ref":"refs/heads/23.05.x","pushedAt":"2024-05-30T19:25:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36723: Add musical presentation to Elasticsearch index mappings\n\nTesting plan:\n\n1. Start up KTD with Elasticsearch: ktd --es8 up\n2. Apply the patch and restart everything (restart_all).\n3. Reset the mappings: Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (at the bottom of the page)\n4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev\n5. Alternative to steps 3 and 4: reset_all\n6. Update the visibility for 254$a in the default framework so that it is visible in the Editor (OPAC, Staff interface should already be selected).\n7. Add a new record using the default framework and put a term in 254$a, such as 'Full score'.\n\nSponsored-by: Education Services Australia SCIS\nSigned-off-by: David Nind <david@davidnind.com>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit fffb3665eadec04792b055e9ba04152b3b36d6dd)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 58052b46f4365b0d5c6729b80a84b7f13ebe6b34)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 36723: Add musical presentation to Elasticsearch index mappings"}},{"before":"35117c339efddf381ce2ad8d982eaad0d714ddce","after":"551248240b6315592bde25219a9b65798513fb25","ref":"refs/heads/23.05.x","pushedAt":"2024-05-30T19:23:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 34823: Do not show Item group dropdown if there are no item groups\n\nTo test:\n1. Enable EnableItemGroups and EnableItemGroupHolds\n2. Go to the OPAC and log in as a patron\n3. Go to any record that doesn't have grouped items and try to place a hold\n4. Click on \"Show more options\"\n5. See \"Request specific item group:\" and dropdown\n6. APPLY PATCH\n7. Try again, this time if the record has no item groups you should not see the dropdown at all.\n\nSigned-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>\nSigned-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>\nSigned-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>\n(cherry picked from commit be98d633be1fb34f52ccc8b57b18280856cf1d1a)\nSigned-off-by: Fridolin Somers <fridolin.somers@biblibre.com>\n(cherry picked from commit 58c25f1c78091c714e24710ca65b8989f02c80b4)\nSigned-off-by: Lucas Gass <lucas@bywatersolutions.com>","shortMessageHtmlLink":"Bug 34823: Do not show Item group dropdown if there are no item groups"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWTCqwgA","startCursor":null,"endCursor":null}},"title":"Activity · Koha-Community/Koha"}