New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to filter out packages by regex #166
Comments
It seems like regular expressions could be too heavyweight (conceptually, not in terms of performance overhead) for this particular problem. Would wildcards (like |
Strong opposition to wildcards. Regex has documentation and years of battle tested usage. Most developers should be familiar with Regexes. Wilcards have different implementations (shell, ant, other?) and it's impossible to tell what to expect without reading through (sometimes absent) documentation. Plus regexes are more flexible. Sorry for the upfront response but I've been burned too many times 😅 |
The flexibility regexes have comes with complexity and it's easy to make a mistake. When applied to package names, it may be too cumbersome to escape every dot in the name to get a semantically correct RE.
One still has to read documentation to figure out if the expression like With wildcards having only From the API point of view, wildcards allow us to continue using the same |
One question is: "does If I want to ignore I've been there with dexguard and to this day I won't be able to tell you if a dexguard rule matches a class name from memory. I wish all string matching used regexes so that I don't have to fit new rules in my brain. Now the BCV use case is probably simpler and you're 100% right about new API. Using just |
Related PR: #121 |
I'd like to exclude all symbols that are in
*.internal
packages. Currently it requires listing them all explicitly, would be nice to be able to specifyignoredPackages
as a list of regexes:The text was updated successfully, but these errors were encountered: