New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure output directory for dumps #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -150,10 +158,10 @@ private class TargetConfig constructor( | |||
val apiDir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move the property above the fun
block?
val root = project.layout.projectDirectory.asFile.toPath().toAbsolutePath().normalize() | ||
val resolvedDir = root.resolve(dir).normalize() | ||
if (!resolvedDir.startsWith(root)) { | ||
throw IllegalArgumentException("apiDumpDirectory should be inside the project directory") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider enriching the message with the contextual information about expected and actual paths
Co-authored-by: Vsevolod Tolstopyatov <qwwdfsad@gmail.com>
(I removed the obsolete comment because I was looking at the wrong branch in my IDE) |
Added an option to configure a path to a directory where dumps are stored:
By default, that path remains
api
.It's an error to specify a path that leads outside the project directory.
Fixes #127