New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java Android Library Support #94
Comments
Good point. I'm not sure how hard it would be to add it and if there are any caveats that may prevent us from implementing it though. I'm ready to properly review and evaluate a contribution (or a PoC) for this functionality |
Unfortunately, Unfortunately, I'm short on time in order to properly investigate and fix it, so in order to unblock libraries from updating, I'm reverting this feature and releasing 0.12.1 |
The first bug in the implementation is its non-laziness, which misses the applied kotlin-android plugin in some scenarios (the expected way to check is The problem itself is deeper -- it's not the plugin check, but the fact these two tasks ( |
I did not test the case where plugin is applied to the root project (as it is recommended). Since the functional tests I added also does not cover this case but instead applies the plugin to the individual java/kotlin modules, I missed it during development. Thanks for sharing your findings, I will look into it asap (hopefully this weekend) and create a new PR to fix the issue. |
No need to hurry, bugs happen. |
Hi @qwwdfsad, it's been a while since I've created a PR for this issue. I'd appreciate if you could take a look when you have a chance. |
Binary compatibility plugin configures necessary tasks like 'apiDump' and 'apiCheck' only if
kotlin
,kotlin-android
orkotlin-multiplatform
plugins are applied as can be seen hereAlthough it can be used for Java libraries, due to missing the plugins listed above, necessary tasks are not created.
Java Android libraries can be supported if the tasks are also created for projects where
com.android.library
plugin is applied.The text was updated successfully, but these errors were encountered: