Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests for unfold #677

Open
Jolanrensen opened this issue Apr 25, 2024 · 1 comment
Open

Missing tests for unfold #677

Jolanrensen opened this issue Apr 25, 2024 · 1 comment
Labels
tests Something related to the JUnit tests, integration tests or testing infrastructure
Milestone
Backlog

Comments

@Jolanrensen
Copy link
Collaborator

As the title says.
Unfold is a sort-of in-dataframe .toDataFrame() conversion (https://kotlin.github.io/dataframe/unfold.html), but this behavior isn't tested anywhere, nor do we check it's consistent with our Iterable<>.toDataFrame() overloads.

Related to unfold, we should probably rename AnyCol.isPrimitive() and KClass<*>.isPrimitive() to isValueType() or something, because "primitive" has a different meaning in the JVM world.
@Jolanrensen Jolanrensen added the tests Something related to the JUnit tests, integration tests or testing infrastructure label Apr 25, 2024
@Jolanrensen Jolanrensen added this to the Backlog milestone Apr 25, 2024
This was referenced Apr 25, 2024
Open
Merged
@Jolanrensen
Copy link
Collaborator Author

Jolanrensen commented Apr 26, 2024 •
edited

Related to #177 (comment) and #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Something related to the JUnit tests, integration tests or testing infrastructure
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@Jolanrensen