Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GFM: Use Markdown syntax to render lists #2098

Merged
merged 2 commits into from Oct 29, 2021
Merged

GFM: Use Markdown syntax to render lists #2098

merged 2 commits into from Oct 29, 2021

Conversation

sgilson
Copy link
Contributor

@sgilson sgilson commented Aug 29, 2021

Addresses #2057

  • Switch list representation in CommonmarkRenderer.kt to use Markdown syntax instead of HTML
  • Add ListBuilder to PageContentBuilder.kt to make testing feasible through builder DSL
  • Switch to non-deprecated JUnit Assert in SimpleElementsTest.kt

@sgilson
Copy link
Contributor Author

sgilson commented Sep 1, 2021

Can this be run again? The errors in the previous build seem related to a lack of memory, but I don't see how this could be related to the changes.

@sgilson
Copy link
Contributor Author

sgilson commented Sep 2, 2021

Updated API file to fix the failing check

@sgilson
Copy link
Contributor Author

sgilson commented Sep 4, 2021

I've tried reproducing the Java 11 and 16 tests locally on my windows machine with the same gradle arguments with no luck. I'm seeing a similar paging/connection reset issue on other PRs, but I'm not exactly sure what could be causing this:

Any thoughts on how to debug this?

@MarcinAman
Copy link
Contributor

Can this be run again? The errors in the previous build seem related to a lack of memory, but I don't see how this could be related to the changes.

JDK 16 on windows sometimes failes as i think they use a weaker machine for that, don't worry.

As for the api check: weird, but i see that it passes now so it is ok

@sgilson
Copy link
Contributor Author

sgilson commented Oct 7, 2021

@MarcinAman given the only tests failing are on the windows machine, what is the route forward?

@MarcinAman
Copy link
Contributor

please rebase and ping @vmishenev for review and testing

@sgilson @sgilson-wdc
- Add ListBuilder to PageContentBuilder.kt to make testing feasible t…
3c5a690 
…hrough the builder DSL

- Switch list representation in CommonmarkRenderer.kt to use Markdown syntax instead of HTML
- Switch to non-deprecated Assert in SimpleElementsTest.kt
@sgilson @sgilson-wdc
Updating base.api to include new builder class and methods
acd8eb7
@sgilson
Copy link
Contributor Author

sgilson commented Oct 9, 2021

Ping @vmishenev. Rebase has been applied

@vmishenev vmishenev self-requested a review October 9, 2021 22:50
@sgilson
Copy link
Contributor Author

sgilson commented Oct 27, 2021

Anything remaining items before this can be merged?

@vmishenev vmishenev merged commit e6ec2ab into Kotlin:master Oct 29, 2021
owengray-google pushed a commit to owengray-google/dokka that referenced this pull request Dec 29, 2021
@sgilson @owengray-google
GFM: Use Markdown syntax to render lists (Kotlin#2098)
1062f9f 
* - Add ListBuilder to PageContentBuilder.kt to make testing feasible through the builder DSL
- Switch list representation in CommonmarkRenderer.kt to use Markdown syntax instead of HTML
- Switch to non-deprecated Assert in SimpleElementsTest.kt

* Updating base.api to include new builder class and methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmishenev vmishenev vmishenev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgilson @MarcinAman @vmishenev