Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support merging to tab view constructors with implicit actuals #2198

Closed
atyrin opened this issue Oct 21, 2021 · 0 comments · Fixed by #2316
Closed

Support merging to tab view constructors with implicit actuals #2198

atyrin opened this issue Oct 21, 2021 · 0 comments · Fixed by #2316
Labels
enhancement An issue for a feature or an overall improvement format: html An issue/PR related to Dokka's default HTML output format

Comments

@atyrin
Copy link
Contributor

atyrin commented Oct 21, 2021

For code like this:

//common
expect class CommonClass()

//platform-1
actual class CommonClass

//platform-2
actual class CommonClass

The same constructors are splitter
image

But if platform implementation will declare explicit actual constructor

actual class CommonClass actual constructor()

then it will be merged correctly
image
@atyrin atyrin added enhancement An issue for a feature or an overall improvement format: html An issue/PR related to Dokka's default HTML output format labels Oct 21, 2021
@vmishenev vmishenev linked a pull request Feb 15, 2022 that will close this issue
Add option to merge implicit expect-actual declarations #2316
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An issue for a feature or an overall improvement format: html An issue/PR related to Dokka's default HTML output format
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to merge implicit expect-actual declarations Kotlin/dokka
1 participant
@atyrin